$mol_audio refactor, added sample and scheduled nodes #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nin-jin
requested changes
Dec 29, 2023
audio/context/context.node.ts
Outdated
| } | ||
| }) | ||
|
|
||
| $.$mol_audio_context = $mol_audio_context_node |
There was a problem hiding this comment.
Возможно даже так можно:
static context() {
return $mol_dom_context.AudioContext || $node['web-audio-api']
}
There was a problem hiding this comment.
да все-равно надо билдер опять фиксить, пока можно стаб оставить, я так и не смог найти
There was a problem hiding this comment.
Не надо тут ничего фиксить, нодовая зависимость должна динамически загружаться.
There was a problem hiding this comment.
Это ж универсальная реализация. Отдельный слайс для ноды не нужен.
nin-jin
reviewed
Dec 29, 2023
audio/context/context.node.ts
Outdated
| } | ||
| }) | ||
|
|
||
| $.$mol_audio_context = $mol_audio_context_node |
There was a problem hiding this comment.
Это ж универсальная реализация. Отдельный слайс для ноды не нужен.
nin-jin
reviewed
Dec 29, 2023
audio/context/context.node.ts
Outdated
| static override create_context(): AudioContext & AudioContextNode { | ||
| const AudioContext = this.$.$node['web-audio-api'].AudioContext | ||
| return new AudioContext() | ||
| } |
There was a problem hiding this comment.
Context() {
return ( this.$.$mol_dom_context || this.$.$node['web-audio-api'] ).AudioContext
}
nin-jin
previously approved these changes
Dec 29, 2023
nin-jin
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.