Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs mol_link_source #629

Merged
merged 3 commits into from
Oct 9, 2023
Merged

add docs mol_link_source #629

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b40dbb
add docs mol_link_source
Sep 9, 2023
5ab40a9
Merge branch 'hyoo-ru:master' into feature/add-mol-link-source-doc
Lyumih Oct 9, 2023
a298f45
move demo
Lyumih Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions link/source/demo.view.tree
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Демки должны быть в отдельным модулях иначе поедут в прод вместе с компонентом.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как вариант на подумать, добавить к компоненту component.view.tree файл с расширением component.view.tree.demo (или другая последовательность c demo) и на уровне бандла выпиливать её. Сейчас папка /demo/ для каждого компонента выглядит неказисто если честно

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Модуль в MAM - это директория. Демки - это отдельные модули со своими отдельными зависимостями.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
$mol_link_source_demo $mol_example_small
title \Link with icon
sub /
<= Blocks $mol_list
rows /
<= Input $mol_string
value? <=> uri? \https://github.com/hyoo-ru/mam_mol/
<= Output $mol_link_source
uri <= uri?
tags /
\link
\icon
\source
\github
\url
aspects /
\Navigation
\Widget/Button
20 changes: 20 additions & 0 deletions link/source/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# $mol_link_source

Hyperlink on source with GitHub icon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю стоит поменять иконку на не связанную с гитхабом.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Захардкожено в самом https://github.com/hyoo-ru/mam_mol/blob/master/link/source/source.view.tree#L4
<= Icon $mol_icon_github_circle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Хотел сначала просто использовать $mol_link_iconed , но она выглядит очень тускло (прозрачно что-ли) по умолчанию и добавляет текст

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно на $mol_icon_script_text_outline поменять.


## [Online demo](https://mol.hyoo.ru/#!section=demos/readme/demo=mol_link_source_demo)

## Usage example

```
<= GitHub $mol_link_source
uri \https://github.com/hyoo-ru/mam_mol/
```
## Extends: [$mol_link](https://mol.hyoo.ru/#!section=demos/readme/demo=mol_link_demo)

## Properties

**`uri() : string`**

Returns target URI.