-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.2 #28
Release 0.2 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you.
I pushed a few things in apache/calcite#3145 and tried to run the
I don't have more time to look into this today but I would suggest to wait till we get this test in plus module to pass. |
@zabetak I agree; this looks like a show-stopper, and we should hold the release until it is resolved. I built a 0.2-SNAPSHOT jar and the |
This error happens if you try to invoke the program from the jar:
Since the files are archived in the jar I am guessing that walkFileTree does not know how to decompress them. |
There is at least one more fix necessary besides fixing the jar file access problem: one needs a handle to the ExecutionOptions to register the CalciteExecutor. I will submit a separate commit for this problem. |
@mihaibudiu, Let me know when you are ready for me to make a release. |
From my point of view this is ready. |
OK, I'll make the release over the weekend. |
@mihaibudiu, When you say "this is ready" are you assuming that I include #35 in the release? It is approved but not yet merged. |
e93eb7b
to
8c3199f
Compare
8c3199f
to
5195b8d
Compare
Fixed in 4bde68b. |
@mihaibudiu and @zabetak, Please review this PR as a candidate for release 0.2. The latest commit contains release notes. The previous commits are those in #25, re-organized slightly.