[QUIDEM-80] Query recorder #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a component that can record queries to Quidem files and play them
back.
Here is an example:
// Step 1. A recorder in RECORD mode creates "foo.iq".
ConnectionFactory postgres;
Config config = Config.empty()
.withFile("foo.iq")
.withMode(RECORD)
.withConnectionFactory(postgres);
Recorder recorder = Recorder.create(config);
recorder.executeQuery("select count(*) from emp", "empCount",
result -> {
assertThat(result.getMetaData().getColumnCount(), is(1));
assertThat(result.next(), is(true));
assertThat(result.getInt(1), is(13));
});
recorder.close();
// Step 2. A recorder in PLAY mode reads "foo.iq" created by step 1.
Config config2 = Config.empty()
.withFile("foo.iq")
.withMode(PLAY);
Recorder recorder2 = Recorder.create(config);
recorder.executeQuery("select count(*) from emp", "empCount",
result -> {
assertThat(result.getMetaData().getColumnCount(), is(1));
assertThat(result.next(), is(true));
assertThat(result.getInt(1), is(13));
});
recorder2.close();
Here is the `foo.iq` file that is generated in step 1 and read in
step 2:
!use "postgres"
# empCount
select count(*) as c from emp;
c:int
======
13
!ok
jswett77
reviewed
Dec 20, 2024
| return wasNull; | ||
| } | ||
|
|
||
| @Override public String getString(int columnIndex) { |
There was a problem hiding this comment.
Having a way to represent an empty string different from null might be useful. Thinking of scenarios where we test grouping sets across edge cases, e.g. empty str, null in same query.
There was a problem hiding this comment.
Great point. I believe the encoding allows us to store both nulls and empty strings, but it's trickier with strings than with data types such as DATE and INTEGER. I will add a test. The following Postgres query seems pretty good:
# with t as (select "ENAME",
# substring("ENAME", 1, mod("MGR",5) - 1) as s
# from emp)
# select s, s is null, char_length(s) from t;
ENAME | s | ?column? | char_length
--------+-----+----------+-------------
SMITH | S | f | 1
ALLEN | AL | f | 2
WARD | WA | f | 2
JONES | JON | f | 3
MARTIN | MA | f | 2
BLAKE | BLA | f | 3
CLARK | CLA | f | 3
SCOTT | | f | 0
KING | | t |
TURNER | TU | f | 2
ADAMS | AD | f | 2
JAMES | JA | f | 2
FORD | | f | 0
MILLER | M | f | 1
(14 rows)
There was a problem hiding this comment.
Commit 7b1a50f should fix this.
…r single-quotes We still cannot encode strings that contain line endings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80