This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
[LATERA-426] Total logging revamp #3
Open
eugenweissbart
wants to merge
6
commits into
hydra-billing:master
Choose a base branch
from
eugenweissbart:no_search_execution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[LATERA-426] Total logging revamp #3
eugenweissbart
wants to merge
6
commits into
hydra-billing:master
from
eugenweissbart:no_search_execution
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed groovy path in build.xml * Added trailing newlines where missing * Fixed execute method declaration in src/bss/executionListeners/abstract_listener.groovy * Fixed alignment in src/bss/executionListeners/init_logging.groovy * Removed unnecessary ignoreSSLIssues call in src/bss/http.groovy * Shortened getLogger declaration in src/bss/http.groovy * Fixed imports for src/homs/eventListeners/auto_save_order_data.groovy * Removed unnecessary orderDataBuffer variable in src/homs/eventListeners/auto_save_order_data.groovy
* Removed commented options in build.xml * Removed unneeded execution variable definition in src/bss/eventListeners/abstract_listener.groovy * Re-implemented detailed log functions in src/bss/eventListeners/event_logging.groovy * Shortened getLogger for src/bss/executionListeners/abstract_listener.groovy too * Fixed alignment in src/homs/executionListeners/finish_order.groovy
- Logger is no longer stored in execution - New class - org.activiti.latera.bss.logging.Logging with getLogger and log methods - getLogger() and log() methods removed from abstractListeners - getLogger() no longer targets DelegateExecutions only but ActivitiEvents too - both have getProcessDefinitionId() and getProcessInstanceId() methods needed to get a logger with similar name - execute() method removed from abstractListeners - sticking to notify() and onEvent() - log() method removed from HTTPRestProcessor - Some syntactic sugar to make the code more comfortable to read - Removed some unneeded declaration modifiers
The already running processes should be fine though (unconfirmed) |
sugarfree1
suggested changes
May 25, 2018
<property name="groovy.version" value="1.8.6" /> | ||
<property name="java.libs" value="/usr/share/java" /> | ||
<property name="groovy.home" value="/usr/local/share/groovy" /> | ||
<property name="groovy.version" value="2.4.12" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have same changes here https://github.com/latera/activiti-ext/pull/2/files. Remove it from one of PRs or you're gonna deal with merge conflicts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!
The newly uploaded/started processes have to:
org.activiti.latera.bss.logging.Logging
on each scripttask where logging is neededLogging.log(String msg, String level='info', Logger logger=null)
method insteaddef logger = Logging.getLogger(execution)
insteadKeep in mind that
Logging.log "${msg}"
would still work but without logger passed it will performprintln("[${level}] ${msg}")
instead so there will be no process id in log outputSame goes to HTTPRestProcessor.sendRequest - it has to have a
logger=logger
parameter otherwise logs will be just println-ed to catalina.out