Skip to content
This repository has been archived by the owner on Mar 9, 2020. It is now read-only.

Design HWSC CLI App #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Design HWSC CLI App #29

wants to merge 2 commits into from

Conversation

dinhl
Copy link
Member

@dinhl dinhl commented May 31, 2019

Task: #25

Create command lines to check ES cluster health

@dinhl dinhl requested review from faraonc, acltang, yeseulan and kimlisa May 31, 2019 01:12
Copy link
Member

@faraonc faraonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just blocking this PR for some minor requests.

cmd/root.go Outdated Show resolved Hide resolved
cmd/version.go Outdated Show resolved Hide resolved
}
fmt.Println(res)
},
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a screenshot of the result when running the command health?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

health

fmt.Println(err)
}
fmt.Println("ElasticSearch version: ", res)
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a screenshot of the result when running the command version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

go.sum Outdated Show resolved Hide resolved
Copy link
Member

@faraonc faraonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More typos

cmd/es_health.go Show resolved Hide resolved
cmd/version.go Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/version.go Outdated Show resolved Hide resolved
cmd/version.go Outdated Show resolved Hide resolved
Copy link
Member

@acltang acltang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all instances of ElasticSearch to Elasticsearch used formally here https://www.elastic.co/products/elasticsearch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants