Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: update file-uploader plugin to v0.0.4. #247

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Sep 16, 2024

fixes #246

@hvlads
Copy link
Owner

hvlads commented Oct 5, 2024

Hi @goapunk

Thank you for your pull request! I appreciate your contribution. However, I noticed that your plugin relies on specific versions of CKEditor 5, which restricts my ability to update the CKEditor packages in the django-ckeditor-5 project.

Due to this, I have temporarily removed your plugin from the code. If you could adjust the dependencies to allow for version flexibility, it would be greatly appreciated.

Thank you!

@goapunk
Copy link
Contributor Author

goapunk commented Oct 14, 2024

@hvlads I will look into it, however relaxing the version requirements might not work as far as I remember. If you check for example the ckeditor image plugin it also pins the dependencies to a specific version: https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-image/package.json

@goapunk goapunk force-pushed the jd-2024-09-update-file-upload-plugin branch from d90cd01 to 7c84081 Compare October 15, 2024 07:09
@goapunk
Copy link
Contributor Author

goapunk commented Oct 15, 2024

@hvlads I updated the plugin with more relaxed requirements, it works again now

@hvlads
Copy link
Owner

hvlads commented Oct 17, 2024

@goapunk
The problem is that when I update CKEditor, all the packages included in it need to have the same version. However, your plugin would still use the old version, which could cause issues.

@goapunk
Copy link
Contributor Author

goapunk commented Oct 17, 2024

@hvlads this should be fixed now I think ? I changed the version requirement to >=41.3.1 (see https://github.com/liqd/ckeditor5-file-uploader/blob/main/package.json#L34) which should cover future versions

@hvlads hvlads merged commit be3fd0d into hvlads:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Couldn't upload file: file.text/html; charset=utf-8
2 participants