Full-Resolution Camera Downloads #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geeoon
force-pushed
the
full-resolution-camera-report
branch
from
a5b5ff9
to
a11c024
Compare
abhaybd
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Overall looks good, just a note that I don't think there's a point in adding a method to the camera stream task. We don't care if the stream has been opened or not, we just want to grab the latest frame from a given camera.
Also note that we should properly handle the case where the returned frame datapoint is empty.
|
This looks great, will merge once the corresponding MC pr has been tested and merged. |
Geeoon
force-pushed
the
full-resolution-camera-report
branch
from
1521299
to
00739b3
Compare
|
Didn't get to this during CIRC, Hutton can handle review and merging. |
huttongrabiel
requested changes
Nov 19, 2024
| @@ -18,11 +18,13 @@ constexpr const char* MOTOR_POSITION_REQ_TYPE = "motorPositionRequest"; | |||
| constexpr const char* JOINT_POSITION_REQ_TYPE = "jointPositionRequest"; | |||
| constexpr const char* CAMERA_STREAM_OPEN_REQ_TYPE = "cameraStreamOpenRequest"; | |||
| constexpr const char* CAMERA_STREAM_CLOSE_REQ_TYPE = "cameraStreamCloseRequest"; | |||
| constexpr const char* CAMERA_FRAME_REQ_TYPE = "cameraFrameRequest"; | |||
There was a problem hiding this comment.
Lets try to make these frozen::string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking the download button will just download the client-side H264 compressed stream, which is fairly low quality. This PR adds the ability to request full-resolution jpg images from the rover, and if the camera is available, a base64 encoded image will be sent to mission control at a much higher resolution than the normal client-side video stream.
Related with huskyroboticsteam/mission-control#71