Report full attitude, fix lat/lon bug, report attitude even if no gps fix #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaybd
force-pushed
the
fix-rover-telem
branch
from
ba55247
to
f331c0a
Compare
huttongrabiel
requested changes
Sep 7, 2023
|
Core code looks good! Everything that stuck out to me was just nitpicky things that you can choose to fix or not. I'm happy to approve as is. |
huttongrabiel
requested changes
Sep 7, 2023
|
Looks good. One minor typo in comment |
huttongrabiel
approved these changes
Sep 7, 2023
|
I'll hold off on merging this until we just verify it works fine on the robot. |
|
Confirm that this works in sim! |
abhaybd
added a commit
that referenced
this pull request
Sep 29, 2023
… fix (#264) * Report full attitude, fix lat/lon bug, report attitude even if no gps fix * Address comments
abhaybd
added a commit
that referenced
this pull request
Oct 10, 2023
* Implement watchdog * Use watchdog in MCP * Address comments * Update camera configs (#263) * Update camera configs * Add comment * Report full attitude, fix lat/lon bug, report attitude even if no gps fix (#264) * Report full attitude, fix lat/lon bug, report attitude even if no gps fix * Address comments * Format code * Address comments
AyushKulk
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Implement watchdog * Use watchdog in MCP * Address comments * Update camera configs (#263) * Update camera configs * Add comment * Report full attitude, fix lat/lon bug, report attitude even if no gps fix (#264) * Report full attitude, fix lat/lon bug, report attitude even if no gps fix * Address comments * Format code * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
readIMU()to the world interface, which allows reading the full attitude. It also includes some refactoring, sincereadIMUHeading()is now obviously a subset ofreadIMU().Also includes a bugfix where
latwas repeated twice instead oflatandlon.