Install hindsightcan with fetchcontent #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaybd
force-pushed
the
update-can-dep
branch
from
eee96b4
to
9b38ba0
Compare
huttongrabiel
previously approved these changes
Sep 29, 2023
huttongrabiel
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that HindsightCAN no longer needs to be installed with
apt-get, and usesFetchContentto fetch it at configure-time instead. This makes it easier to develop in the future, and removes the hassle of managing that dependency in the ubuntu repo.This should be merged after the corresponding PR in HindsightCAN: huskyroboticsteam/HindsightCAN#47
Note: remember to update the commit hash in CMakeLists.txt after merging the above pr.