Applied xml schemas for xmllint #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Comment on lines
+75
to
+78
| - repo: https://github.com/comkieffer/pre-commit-xmllint.git | ||
| rev: 1.0.0 | ||
| hooks: | ||
| - id: xmllint |
There was a problem hiding this comment.
IMO doesn't work without shema arg. To test it you can try modyfy package.xml and pre-commit run -a.
But adding schema makes issue with microros.xml. I to fix this, but I cannot find info how to ignore single file.
rafal-gorecki
changed the title
DominikN
added a commit
that referenced
this pull request
Dec 5, 2024
* Cleaner logs from flash script (#108) * Clean up output of flash script * Pre commit * Cleaner * Specify concrete commands * Simplify * pre-commit fix * Clean up usb firmware * Clean up unused arguments (#118) * Add scan filter * Clean up * undo * added docker setup for local build * broken ros2 controller - previous worked fine * Clean up unused arguments * Fix workflow: Remove spellcheck (redundant), fix integration check * Fix multiple robot spawn * fixes * Delete tools folder * Pre-commit update and remove redundant flake8 * Fix some tests and set hash in vcs * Clean up * Move controller test to bringup and reduce test time * Fix lidar in simulation * Rename test files * Fix tests * Add scan_filtered test and improve workpace tree --------- Co-authored-by: Dominik Nowak <[email protected]> * Applied xml schemas for xmllint (#101) * applied package.xml template Signed-off-by: Jakub Delicat <[email protected]> * chronology Signed-off-by: Jakub Delicat <[email protected]> * Support Signed-off-by: Jakub Delicat <[email protected]> * Removed unnecessary dep Signed-off-by: Jakub Delicat <[email protected]> * DDS xml lint --------- Signed-off-by: Jakub Delicat <[email protected]> Co-authored-by: rafal-gorecki <[email protected]> * Pre-commit * Humble docker (#124) * Add hardware and sim Docker * Fix hardware docker * Fixes * Use packages-up-to * Add description to compose * Add healthcheck + clean up * Add healthcheck + clean up * Remove combined.launch.py * Add User env to docker * Change healthcheck * Clean up * Update docs * Add launch arguments info * Add status info * add unsaved * fix * Simplify --------- Signed-off-by: Jakub Delicat <[email protected]> Co-authored-by: Dominik Nowak <[email protected]> Co-authored-by: Jakub Delicat <[email protected]>
DominikN
added a commit
that referenced
this pull request
Dec 11, 2024
* support for RPi5 * restart ros2_control_node if error * minor fixes * Update controller.launch.py * fix mecanum lauch * Fix controller namespace (#115) * Fix controller namespace * spellcheck fix * use husarion-controller from main branch (#116) * added docker setup for local build * ros2 humble works without custom controllers * Cleaner logs from flash script (#108) * Clean up output of flash script * Pre commit * Cleaner * Specify concrete commands * Simplify * pre-commit fix * Clean up usb firmware * Clean up unused arguments (#118) * Add scan filter * Clean up * undo * added docker setup for local build * broken ros2 controller - previous worked fine * Clean up unused arguments * Fix workflow: Remove spellcheck (redundant), fix integration check * Fix multiple robot spawn * fixes * Delete tools folder * Pre-commit update and remove redundant flake8 * Fix some tests and set hash in vcs * Clean up * Move controller test to bringup and reduce test time * Fix lidar in simulation * Rename test files * Fix tests * Add scan_filtered test and improve workpace tree --------- Co-authored-by: Dominik Nowak <[email protected]> * Applied xml schemas for xmllint (#101) * applied package.xml template Signed-off-by: Jakub Delicat <[email protected]> * chronology Signed-off-by: Jakub Delicat <[email protected]> * Support Signed-off-by: Jakub Delicat <[email protected]> * Removed unnecessary dep Signed-off-by: Jakub Delicat <[email protected]> * DDS xml lint --------- Signed-off-by: Jakub Delicat <[email protected]> Co-authored-by: rafal-gorecki <[email protected]> * Some fixes * test * Pre-commit * pre-commit * Humble docker (#124) * Add hardware and sim Docker * Fix hardware docker * Fixes * Use packages-up-to * Add description to compose * Jazzy docker (#125) * Add hardware and sim Docker * Fix hardware docker * Fixes * Fixes * Simulation gz_gui fixes + use TwistStamped * Use packages-up-to * Add healthcheck + clean up * Add healthcheck + clean up * Remove combined.launch.py * Add User env to docker * Add devcontainer * Changes in healthcheck * Fix simulation * Red error info * Change healthcheck * Remove healthcheck arg * Fix workflow * Remove building imu_broadcaster * One more removal * update repos * Clean up * Update docs * Add launch arguments info * Add status info * add unsaved * fix * Simplify * Update URDF, fix mecanum sim, fix laser_filter ns, remove tf renaming * pre-commit * Fix ros2 controller with namespace * Fix building instructions * Fix indent * Fix mecanum controller * Remove camera test from sim * update * Adjust wheel_separation_multiplier param * Simplify docker --------- Signed-off-by: Jakub Delicat <[email protected]> Co-authored-by: dominikn <[email protected]> Co-authored-by: Jakub Delicat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the package.xml according https://github.com/colcon/colcon-bundle/blob/master/integration/test_workspace/src/test-nodes/package.xml and the schema template http://download.ros.org/schema/package_format3.xsd .
Added scheme for fastrpts xml config
Added pre-commit hook to prevent incompatibilities with http://download.ros.org/schema/package_format3.xsd
bump::patch