Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CRSF teleop #1

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Implement CRSF teleop #1

merged 11 commits into from
Dec 3, 2024

Conversation

miloszlagan
Copy link
Contributor

No description provided.

@miloszlagan miloszlagan requested a review from delihus November 26, 2024 14:04
delihus
delihus requested changes Nov 26, 2024
View reviewed changes
Copy link

@delihus delihus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the "magic numbers" if it is possible and remove unnecessary comments using smaller functions.

Please add precommit to format files.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
compose.yml Outdated Show resolved Hide resolved
husarion_ugv_crsf_interfaces/CMakeLists.txt Outdated Show resolved Hide resolved
husarion_ugv_crsf_teleop/husarion_ugv_crsf_teleop/crsf_teleop_node.py Outdated Show resolved Hide resolved
husarion_ugv_crsf_teleop/husarion_ugv_crsf_teleop/crsf_teleop_node.py Show resolved Hide resolved
husarion_ugv_crsf_teleop/husarion_ugv_crsf_teleop/crsf_teleop_node.py Outdated Show resolved Hide resolved
husarion_ugv_crsf_teleop/husarion_ugv_crsf_teleop/crsf_teleop_node.py Outdated Show resolved Hide resolved
husarion_ugv_crsf_teleop/test/test_copyright.py Outdated Show resolved Hide resolved
@miloszlagan miloszlagan requested a review from delihus November 29, 2024 11:10
@miloszlagan miloszlagan merged commit 7482522 into master Dec 3, 2024
1 check passed
@miloszlagan miloszlagan deleted the dev branch December 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delihus delihus delihus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miloszlagan @delihus