Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): Mirror Card title size to shadcn-ui #1488

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Nov 15, 2024

Fixes #1483

Also fixes heading size to be the same on the default component.

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: a1ea2fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview a1ea2fe

@huntabyte
Copy link
Owner

I could have sworn this was added recently, let me look for the PR

@huntabyte
Copy link
Owner

Yeah here it is: #1211

This seems more reasonable IMO unless there is a drawback I'm missing? It's weird that there is inconsistencies between the header/footer in the original

@ieedan
Copy link
Contributor Author

ieedan commented Nov 15, 2024

Yeah here it is: #1211

This seems more reasonable IMO unless there is a drawback I'm missing? It's weird that there is inconsistencies between the header/footer in the original

Yeah that does make more sense than the original. Let me modify this PR to just fix the title size instead.

@ieedan ieedan changed the title fix: Card styling differences from shadcn-ui fix(next): Mirror Card title size to shadcn-ui Nov 15, 2024
@ieedan
Copy link
Contributor Author

ieedan commented Nov 15, 2024

Should be good now!

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit 65b8769 into huntabyte:next Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants