You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the ability to set portal on dialog content (for both Dialog and AlertDialog). It used to be on Dialog.Root But I didn't know how to add it back there so I just added to Dialog.Content and AlertDialog.Content.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
In this case, we'd need to add it to all the floating elements, and a more flexible approach would probably be a portalProps type which includes all the possible props to pass to Portal
In this case, we'd need to add it to all the floating elements, and a more flexible approach would probably be a portalProps type which includes all the possible props to pass to Portal
Hopefully these modifications are what you wanted?
@saturnonearth yes, but let's make the name portalProps instead of just portal. Having a portal prop instantly makes me think it's going to be a boolean whereas portalProps is a bit more explicit.
huntabyte
changed the title
feat (next): Add ability disable portal for dialogs
feat (next): Add ability disable portal for portalled components
Nov 20, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huntabyte
changed the title
I added the ability to set portal on dialog content (for both
DialogandAlertDialog). It used to be onDialog.RootBut I didn't know how to add it back there so I just added toDialog.ContentandAlertDialog.Content.Edit: I added same props to
Popoveras well.