Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin svelte-radix version for Svelte 4 support #1478

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Nov 12, 2024

Looks like 1.1.1 is the latest version of radix for svelte 4.

P.S. I think the registry needs to be built but the build is broken on windows (I only have access to a windows machine rn) so you may need to build and commit.

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: cff9f7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ieedan
Copy link
Contributor Author

ieedan commented Nov 12, 2024

Fixes #1473

Copy link
Contributor

github-actions bot commented Nov 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview cff9f7b

@huntabyte
Copy link
Owner

The registry rebuilds during CI before deployment which is why removed it from next so no worries there.

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit fa6e876 into huntabyte:main Nov 12, 2024
4 checks passed
@ieedan ieedan deleted the pin-radix branch November 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants