Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Header component has different padding than original repo #1483

Closed
Infiniti20 opened this issue Nov 14, 2024 · 0 comments
Closed

Card Header component has different padding than original repo #1483

Infiniti20 opened this issue Nov 14, 2024 · 0 comments

Comments

@Infiniti20
Copy link

Infiniti20 commented Nov 14, 2024

Describe the bug

The Card Header component removes padding on the bottom, while this behaviour was changed in the original shadcn ui.

card-header.svelte (shadcn-svelte)

<div bind:this={ref} class={cn("flex flex-col space-y-1.5 p-6 pb-0", className)} {...restProps}>
	{@render children?.()}
</div>

card.tsx (shadcn)

const CardHeader = React.forwardRef<
  HTMLDivElement,
  React.HTMLAttributes<HTMLDivElement>
>(({ className, ...props }, ref) => (
  <div
    ref={ref}
    className={cn("flex flex-col space-y-1.5 p-6", className)}
    {...props}
  />
))
CardHeader.displayName = "CardHeader"

Reproduction

Logs

-

System Info

-

Severity

annoyance

@huntabyte huntabyte added status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 14, 2024
ieedan added a commit to ieedan/shadcn-svelte that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants