-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maulana Ghozi Humama #2
base: master
Are you sure you want to change the base?
Conversation
environment variable : feature tambahan: hambatan : expect yang tidak terwujud :
|
testing : |
@@ -0,0 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ini sebaiknya di ignore, tidak boleh share data credential di github
@@ -0,0 +1,9 @@ | |||
PORT=3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ini jg harusnya di ignore, tidak boleh share di github
} | ||
|
||
const express = require('express') | ||
const axios = require('axios') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kenapa menggunakan axios di sini?
const morgan = require('morgan') | ||
|
||
mongoose.connect(process.env.BASE_URL, { useNewUrlParser : true, useUnifiedTopology: true, useCreateIndex : true }) | ||
.then(success => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tidak menerima parameter apa2 di sini
app.use(morgan('combined')) | ||
|
||
app.get('/', (req, res) => { | ||
res.send(`Mantappp Connect CCCUUUUKKKKK`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mantap cuk!
|
||
const userSchema = new Schema({ | ||
name: String, | ||
email: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lakukan validasi juga apakah email unique atau tidak
@@ -0,0 +1,10 @@ | |||
const { varify } = require('../helpers/jwt') | |||
module.exports = (req, res, next) => { | |||
try{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tips: lakukan pengecekan juga apakah user ada atau tidak di database
|
||
<body> | ||
<div id="App"></div> | ||
<script src="https://cdn.jsdelivr.net/npm/sweetalert2@8"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ketika menggunakan npm install, tidak perlu lagi menggunakan CDN
<script src="https://cdn.jsdelivr.net/npm/sweetalert2@8"></script> | ||
<script src="https://apis.google.com/js/platform.js" async defer></script> | ||
<script src="https://apis.google.com/js/api:client.js"></script> | ||
<script src="https://kit.fontawesome.com/5cd1e1d933.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kalo dari data network ini yang bkin berat
ketika menjalankan versi yang sudah di deploy, aplikasi berat dan tidak bisa melakukan apa2(?)
Jika ada perubahan/ tambahan, kabari instructor yaa |
# Hackticle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coba nanti dilengkapi :D
No description provided.