Layout #1

Cado21 · 2019-09-09T10:47:36Z

.env template ada di folder server "env-template"

CLIENT_ID=397711291646-fgrnl8h2969mqm5fd2ufmjthm4kv36p5.apps.googleusercontent.com
PORT=3000
DATABASE_URL=mongodb://localhost:27017/mini-wp
SECRET_JWT=SECRETWOI
SALT_ROUND=10
DEFAULT_PASSWORD=DEFAULT
CLOUD_BUCKET=deeppress
GCLOUD_PROJECT=deeppress
KEYFILE_PATH=keyfile.json

Feature Tambahan:

Article bisa diberi Tag
Filter bukan cuma berdasarkan title tetapi tag juga ada
Ada page untuk melihat detail artikel yang di post

Kendala :

Website deploy lemot, ketika barusan login trus ganti orang lain login lama fetchnya..
suka kena status bad gateway

link : http://deeppress.cado.store/

WikaSilo · 2019-09-19T10:41:50Z

server/env-template.txt

@@ -0,0 +1,9 @@
+CLIENT_ID=397711291646-fgrnl8h2969mqm5fd2ufmjthm4kv36p5.apps.googleusercontent.com


ketika membuat template, tidak perlu memasukan credential valuenya

WikaSilo · 2019-09-19T11:38:38Z

server/app.js

+mongoose.connect( DATABASE_URL , { useNewUrlParser : true })
+    .then( () => { console.log( `Database connected to: ${DATABASE_URL}` ); })
+    .catch( err =>{ console.log( err ); })
+mongoose.set('useCreateIndex', true);


bisa dijadikan satu di confignya saat connect

WikaSilo · 2019-09-19T11:39:09Z

server/models/user.js

+        type : String,
+        required : true
+    },
+    email : {


kenapa tidak dibuat untuk check unique?

WikaSilo · 2019-09-19T11:40:06Z

server/middleware/errorHandler.js

+    let status ;
+    let message;
+
+    if ( err.name == 'ValidationError' ) {


jangan hanya seperti ini, jadi sia-sia jika sudah membuat custom message di validasi model. gunakan custom message untuk dikirimkan ke client

WikaSilo · 2019-09-19T11:40:24Z

server/middleware/authentication.js

+
+// Check if the user bring token; if not let user know they must login 
+function authentication ( req ,res , next ) {
+    try {


tips: ada pengecekan user apakah masih ada atau tidak di database

WikaSilo · 2019-09-19T11:40:57Z

server/controllers/article.js

@@ -0,0 +1,117 @@
+const Article = require('../models/article');
+class ArticleController {


tidak selalu semuanya populate data user, karena akan mendapatkan passwordnya

WikaSilo · 2019-09-19T11:42:08Z

client/js/components/EditArticle.vue

+                })  
+                return;
+            }
+            if ( !this.file ) {


jika ketika edit tidak mengirimkan photo, bisa menggunakan photo yang lain

WikaSilo · 2019-09-19T11:46:40Z

Cado, sekali lagi mengingatkan yaa :D
untuk styling penulisan mu yang seperti ini:

app.use(logger('dev'))
app.use( cors() )

mohon konsistensi ketika memberika spasi setelah (), jika memang itu yang dipilih berarti semuanya juga harus diubah seperti itu, semisal:

app.use( express.urlencoded({ extended : true }));
// seharusnya menjadi
app.use( express.urlencoded({ extended : true }) );

jadi kalo diperhatiin ada ketidak konsistenan (biasanya) di akhir coding

berikut tambahan lainnya:

ketika update article, UX sebenarnya tidak perlu upload gambar lain jika memang gambarnya tidak ingin diubah, bisa di handle di state

overall sudah OK, jika ada tambahan dan perubahan, kabari instructor

layot

1555df2

Cado21 assigned WikaSilo Sep 9, 2019

Cado21 added 12 commits September 10, 2019 21:38

vue

75c4655

coba deploy GCP?

b9fec99

lagi

bd451f7

tambahin route testing

8ab1124

coba deploy

0297079

deploy selesai

c23fc93

finished

65dee26

deploy

4bd613b

selesai

b6e1732

commit localhost

1c628e0

readme documentation

d9379be

env template

74f6ff1

WikaSilo reviewed Sep 19, 2019

View reviewed changes

server/models/user.js

type : String,

required : true

},

email : {

Copy link

Collaborator

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kenapa tidak dibuat untuk check unique?

WikaSilo reviewed Sep 19, 2019

View reviewed changes

benerin yang dikomentarin

d8bc278

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Layout #1

Layout #1

Cado21 commented Sep 9, 2019 •

edited

Loading

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo Sep 19, 2019

WikaSilo commented Sep 19, 2019

		@@ -0,0 +1,9 @@
		CLIENT_ID=397711291646-fgrnl8h2969mqm5fd2ufmjthm4kv36p5.apps.googleusercontent.com

		@@ -0,0 +1,117 @@
		const Article = require('../models/article');
		class ArticleController {

Layout #1

Are you sure you want to change the base?

Layout #1

Conversation

Cado21 commented Sep 9, 2019 • edited Loading

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo Sep 19, 2019

Choose a reason for hiding this comment

WikaSilo commented Sep 19, 2019

Cado21 commented Sep 9, 2019 •

edited

Loading