Handle missing metadata #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain situations, especially with migrated legacy content, an image URL may be sent to tachyon for an image which doesn't exist on disk and may not have any stored metadata. In this case, because we never check that the meta array is well formed and didn't return as "false", several log warnings will be emitted: ``` Trying to access array offset on value of type bool | …achyon-plugin/inc/class-tachyon.php#631 Trying to access array offset on value of type bool | …achyon-plugin/inc/class-tachyon.php#632 ``` Almost all of our calculations in this `if` block assume that meta exists and ws returned as an array. If that's not true, we should move on to compute entirely based on the provided arguments.
kovshenin
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, especially with migrated legacy content, an image URL may be sent to tachyon for an image which doesn't exist on disk and may not have any stored metadata. In this case, because we never check that the meta array is well formed and didn't return as "false", several log warnings will be emitted:
(Observed in Altis 12 on PHP 8—it's very noisy.)
Almost all of our calculations in this
ifblock assume that meta exists and ws returned as an array. If that's not true, we should move on to compute entirely based on the provided arguments.Relates to #69 (and probably #60)