Allow notifications for private posts and comments on private posts #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces a new filter `falcon.connector.wordpress.notify_on_private` (default: `false`). - Duplicates `notify_on_publish()` method as `notify_on_private()` and its filter `falcon.connector.wordpress.should_notify_publish` as `falcon.connector.wordpress.should_notify_private`; does the exact same thing as the original, but for private posts. - Adds a new check for comments on private posts in `notify_on_reply()`, based on the new `falcon.connector.wordpress.notify_on_privat` filter and a post status of `private`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
falcon.connector.wordpress.notify_on_private(default:false).notify_on_publish()method asnotify_on_private()and its filterfalcon.connector.wordpress.should_notify_publishasfalcon.connector.wordpress.should_notify_private; does the exact same thing as the original, but for private posts. (I’m not entirely sure if the duplicate is really necessary, or ifnotify_on_publish()could just be modified, but I didn’t see any straightforward way, so I went with this.)notify_on_reply(), based on the newfalcon.connector.wordpress.notify_on_privatfilter and a post status ofprivate.Granted this is quite an opionated use case. 🙂 I added it on my blog over the weekend where I’m allowing my registered subscribers to view and comment on private posts, and with these changes, notifications work neatly. Didn’t test it with commenting via email, though, as I’m not using that feature.