30 support asctime field for timestamp #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
reviewed
Dec 9, 2024
json_handler_test.go
Outdated
| @@ -153,3 +154,26 @@ func TestJSONHandler_UnmarshalJSON_ParsesCustomMultiNestedFields(t *testing.T) { | |||
| t.Fatalf("not equal: expected %q, got %q", tm, h.Time) | |||
| } | |||
| } | |||
|
|
|||
| func TestParseAsctimeFields_1(t *testing.T) { | |||
| raw := []byte(`{"asctime": ["12-05-05 22:11:08,506248"]}`) | |||
There was a problem hiding this comment.
maybe pull these in a table-test?
There was a problem hiding this comment.
There's an issue with asctime since it doesn't include timezone information. For now, my implementation assumes the parsed time is in UTC, this assumption may be incorrect depending on the user application's logging configuration.
There was a problem hiding this comment.
there's a config value for this on the config struct 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.