Refactoring use-echarts hook #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request includes improvements to the
EChartcomponent and introduces several utility functions to enhance the functionality and maintainability of the ECharts integration in the codebase.⛳️ Current behavior (updates)
The current
use-echarts.tsxfile includes a lot of code and is hard to understand and maintain. Also functions unrelated to state are unitized within the hook. Which has performance implications.🚀 New behavior
The changes include the addition of detailed documentation, restructuring of the component's initialization and event handling, and the introduction of utility functions for ECharts setup and configuration.
💣 Is this a breaking change (Yes/No)
No
📝 Additional Information
This was tested using the project in the example folder. During my testing I was unable to find any regressions that this refactoring me cause