⚙️ Fix Integration Test for TGI #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengomucho
reviewed
Dec 2, 2024
|
|
||
| class LauncherHandle: | ||
| def __init__(self, port: int): | ||
| self.client = AsyncClient(f"http://localhost:{port}") | ||
| self.client = AsyncClient(f"http://localhost:{port}", timeout=600) | ||
| self.logger = logging.getLogger(self.__class__.__name__) |
There was a problem hiding this comment.
note we use loguru elsewhere for logging
There was a problem hiding this comment.
Refactored with loguru
| "LOG_LEVEL": "info,text_generation_router,text_generation_launcher=debug", | ||
| "MAX_BATCH_SIZE": "4", | ||
| "HF_HUB_ENABLE_HF_TRANSFER": "0", | ||
| "JETSTREAM_PT": "1", |
There was a problem hiding this comment.
you can remove this one now
There was a problem hiding this comment.
I moved it to a model config dict, so the arguments can be added for each models. I prefer to leave keep log_level as it allows for easier debugging in case a test fails
| import Levenshtein | ||
| import pytest | ||
|
|
||
| MODEL_ID = "google/gemma-2b-it" |
There was a problem hiding this comment.
wouldn't it be possible to have a single test file with different parameters per model instead of having a new file?
There was a problem hiding this comment.
Refractored the different test files into a single file where you can have a list of configs
baptistecolle
force-pushed
the
fix-integration-test-tgi-without-ci
branch
from
7dc97f2 to
9e63ff2
Compare
baptistecolle
force-pushed
the
fix-integration-test-tgi-without-ci
branch
2 times, most recently
from
a7243e8 to
c5eaa0a
Compare
baptistecolle
force-pushed
the
fix-integration-test-tgi-without-ci
branch
from
c5eaa0a to
1af9edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes broken TGI integration tests and adds Gemma model test
Changes
Notes
This PR is currently not integrated with CI due to some issue with Docker-in-Docker (DinD) on the GitHub runners