Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multi-agent RAG system recipe 🧑‍🍳️ #238

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sergiopaniego
Copy link
Contributor

What does this PR do?

Fixes #237

Who can review?

@merveenoyan and @stevhliu

cc @aymeric-roucher

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:07Z
----------------------------------------------------------------

Great recipe, thanks a lot @sergiopaniego for contributing this 🤗


Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:08Z
----------------------------------------------------------------

Great graph! 👏


Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:09Z
----------------------------------------------------------------

Could you use !pip install transformers[agents]? Or maybe you need the latest releases?


Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:09Z
----------------------------------------------------------------

Good LLM choice!


Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:10Z
----------------------------------------------------------------

You can add a mention like "ReactJsonAgent is generally good for web search, since JSON action formulation needs only simple args and is well-suited to sequential chains of single actions, as opposed to Code action formulation being better suited for numerous or parallel tool calls."


Copy link

review-notebook-app bot commented Nov 22, 2024

View / edit / reply to this conversation on ReviewNB

aymeric-roucher commented on 2024-11-22T15:53:11Z
----------------------------------------------------------------

Here rather than using gradio_tools,you could directly load the space using the new from_space option (read more in the doc):

prompt_generator_tool = Tool.from_space("microsoft/Promptist", **other_args)


@aymeric-roucher
Copy link
Collaborator

aymeric-roucher commented Nov 22, 2024

Great work @sergiopaniego, thanks a lot. Left a few suggestions!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@aymeric-roucher aymeric-roucher removed their request for review November 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Multi-agent RAG System recipe 🧑‍🍳️
3 participants