Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: Data Analyst agent into Korean #212

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

translation: Data Analyst agent into Korean #212

wants to merge 23 commits into from

Conversation

ahnjj
Copy link

@ahnjj ahnjj commented Oct 3, 2024

What does this PR do?

this is PR presents the korean translation of Data analyst agent: get your data’s insights in the blink of an eye ✨ cookbook.

Who can review?

@jeongiin, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ahnjj ahnjj marked this pull request as ready for review October 5, 2024 08:26
@merveenoyan
Copy link
Collaborator

@ahnjj 고맙습니다 once it's reviewed by another Korean speaker we can merge 🫰🏻

@jun048098
Copy link
Contributor

LGTM! 번역 감사합니다!

@merveenoyan
Copy link
Collaborator

@ahnjj we just merged a Korean recipe, toctree and index md has a merge conflict. Can you resolve it? We can merge afterwards.

ahnjj
ahnjj commented Oct 24, 2024
View reviewed changes
notebooks/ko/index.md Outdated Show resolved Hide resolved
notebooks/ko/_toctree.yml Show resolved Hide resolved
@merveenoyan
Copy link
Collaborator

Sorry, another Korean recipe was merged, can you resolve again and we can merge this one
Also feel free to send a join request to this org.

ahnjj
ahnjj commented Oct 27, 2024
View reviewed changes
notebooks/ko/_toctree.yml Show resolved Hide resolved
notebooks/ko/index.md Show resolved Hide resolved
@ahnjj
Copy link
Author

ahnjj commented Oct 27, 2024

Sorry, another Korean recipe was merged, can you resolve again and we can merge this one Also feel free to send a join request to this org.

Thank you for your help!
Since I've just resolved this, can you help with me to be merged?

ahnjj
ahnjj commented Oct 27, 2024
View reviewed changes
notebooks/ko/_toctree.yml Outdated Show resolved Hide resolved
ahnjj
ahnjj commented Oct 27, 2024
View reviewed changes
notebooks/ko/_toctree.yml Outdated Show resolved Hide resolved
jun048098
jun048098 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@jun048098 jun048098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM approve change

@merveenoyan
Copy link
Collaborator

@ahnjj if you can resolve the merge conflict we can merge
also don't forget to join this org: https://huggingface.co/huggingcooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jun048098 jun048098 jun048098 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnjj @merveenoyan @jun048098