Updated PUBLISH.md and fixed a bug

hudec117 · Dec 14, 2023 · 9076064 · 9076064
1 parent 225501e
commit 9076064
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/PUBLISHING.md b/PUBLISHING.md
@@ -1,10 +1,11 @@
 # Publishing
 
 ## General
-- Ensure the version in `manifest.json`, `package.json` and `src/components/PopoutCardFooter.vue` are updated.
+- Ensure the version in `public/manifest.json`, `package.json` and `src/components/PopoutCardFooter.vue` are updated.
 
 ## Chrome
-1. Build production version by running `npm run build-prod`
-2. Side load the `dist` folder into Chrome and test it works correctly.
-3. Zip up all the files inside the `dist` folder and name it `sf-niknax-VERSION-chrome.zip`
-4. Upload new version to Chrome Developer Dashboard
+1. Delete the contents of the `dist` folder. (if it has any)
+2. Build a production version by running `npm run build-prod`
+3. Side load the `dist` folder into Chrome and test it works correctly.
+4. Zip up all the files inside the `dist` folder and name it `sf-niknax-VERSION-chrome.zip`
+5. Upload new version to Chrome Developer Dashboard
diff --git a/src/components/GroupMemberships.vue b/src/components/GroupMemberships.vue
@@ -30,7 +30,7 @@ const assignedGroups = ref<Array<Group>>([]);
 let originalAssignedGroups: Array<Group>;
 
 const title = ref('');
-const primaryButtonError = ref('');
+const primaryButtonError = ref<string | undefined>();
 const showAPINames = ref(false);
 const loading = ref(true);
 const working = ref(false);
@@ -317,7 +317,10 @@ async function unassignGroups(groups: Array<Group>): Promise<boolean> {
                     </button>
 
                     <!-- Error popover -->
-                    <ErrorPopover :message="primaryButtonError" :right="44" :top="55" />
+                    <ErrorPopover :message="primaryButtonError"
+                                  :right="44"
+                                  :top="55"
+                                  @close="primaryButtonError = undefined" />
                 </div>
             </header>
         </div>

diff --git a/src/components/QuickCreateUser.vue b/src/components/QuickCreateUser.vue
@@ -507,10 +507,16 @@ async function closeWindow() {
                     </button>
 
                     <!-- Primary button popover -->
-                    <ErrorPopover :message="primaryButtonError" :right="51" :top="55" @close="primaryButtonError = undefined" />
+                    <ErrorPopover :message="primaryButtonError"
+                                  :right="51"
+                                  :top="55"
+                                  @close="primaryButtonError = undefined" />
 
                     <!-- Clone button popover -->
-                    <ErrorPopover :message="cloneButtonError" :right="175" :top="55" @close="cloneButtonError = undefined" />
+                    <ErrorPopover :message="cloneButtonError"
+                                  :right="175"
+                                  :top="55"
+                                  @close="cloneButtonError = undefined" />
                 </div>
             </header>
         </div>