Replace team_abbr and model_abbr output columns with model_id #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt rightly pointed out that strings are more readable this way (and it turns out we're using f-strings in the logger throughtout the rest of the code base anyway!)
lmullany
reviewed
May 9, 2024
| model_id_split = re.split(rf"{round_id}[-_]*", file_name) | ||
| if not model_id_split or len(model_id_split) <= 1 or not model_id_split[-1]: | ||
| raise ValueError(f"Unable to get model_id from file name {file_name}.") | ||
| model_id = "".join(model_id_split[-1].split()) |
There was a problem hiding this comment.
this removes any spaces in whatever is remaining. Is that your intent? So 2022-12-31-my team-my model.parquet would return "myteam-mymodel" for model_id
There was a problem hiding this comment.
Good call-out. It was my intent at the time I made the pull request, but I have another in the queue (started after Wednesday's dev meeting) that retains the spaces and adds some corresponding test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2
Given @lmullany's findings when converting the archived FluSight repo into hubverse format, we made a decision to simplify how we're parsing model-output file names.
TL;DR: instead of creating separate model and team abbr columns in the transformed parquet file, we're going to create a single
model_idcolumn (see the linked issue for more details).This PR also sneaks in a minor change to logging strings based on feedback from @matthewcornell