Return early if check for valid values fails

hubverse-org · Sep 28, 2023 · 97b0955 · 97b0955
1 parent f2921cf
commit 97b0955
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/R/check_tbl_values.R b/R/check_tbl_values.R
@@ -1,7 +1,7 @@
 #' Check model output data tbl contains valid value combinations
 #'
 #' @inherit check_tbl_colnames params
-#' @inherit check_tbl_col_types return
+#' @inherit check_tbl_colnames return
 #' @export
 check_tbl_values <- function(tbl, round_id, file_path, hub_path) {
   config_tasks <- hubUtils::read_config(hub_path, "tasks")
@@ -43,6 +43,7 @@ check_tbl_values <- function(tbl, round_id, file_path, hub_path) {
     msg_subject = "Data rows",
     msg_attribute = "valid value combinations",
     msg_verbs = c("contain", "do not contain"),
+    error = TRUE,
     details = details
   )
 }
diff --git a/man/check_tbl_values.Rd b/man/check_tbl_values.Rd
diff --git a/tests/testthat/_snaps/check_tbl_values.md b/tests/testthat/_snaps/check_tbl_values.md
@@ -14,7 +14,7 @@
       check_tbl_values(tbl = tbl, round_id = round_id, file_path = file_path,
         hub_path = hub_path)
     Output
-      <warning/check_failure>
-      Warning:
-      Data rows do not contain valid value combinations Affected rows: 1
+      <error/check_error>
+      Error:
+      ! Data rows do not contain valid value combinations Affected rows: 1