redefine model output representation to be two columns #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah crap. This was part of my changes in #197 🙈 |
zkamvar
changed the title
LucieContamin
approved these changes
Oct 23, 2024
zkamvar
requested changes
Oct 23, 2024
Co-authored-by: Zhian N. Kamvar <[email protected]>
Co-authored-by: Zhian N. Kamvar <[email protected]>
zkamvar
requested changes
Oct 24, 2024
|
Hi @zkamvar ! Thanks for looking at the page more carefully. I accepted the changes you suggested and edited line 81. I hope that works for you. |
zkamvar
requested changes
Oct 24, 2024
| @@ -78,7 +78,7 @@ Much of the material in this section has been excerpted or adapted from the [hub | |||
|
|
|||
| _Model outputs are a specially formatted tabular representation of predictions._ | |||
| Each row corresponds to a unique prediction, and each column provides information about what is being predicted, its scope, and its value. | |||
| Per hubverse convention, **there are two groups of columns**[^model-id], each group serving a specific purpose: (1) the **"task ID"** columns provide details about what is being predicted, and (2) the three **"model output representation"** columns specifies the type of prediction, identifying information about that prediction, and the value of the prediction. | |||
| Per hubverse convention, **there are two groups of columns and one column for model output**[^model-id]. Each group of columns serves a specific purpose: (1) the **"task ID"** columns provide details about what is being predicted, and (2) the two **"model output representation"** columns specify the type of prediction, and identifying information about that prediction. Finally, (3) the **value** column provides the model output of the prediction. | |||
There was a problem hiding this comment.
Suggested change
| Per hubverse convention, **there are two groups of columns and one column for model output**[^model-id]. Each group of columns serves a specific purpose: (1) the **"task ID"** columns provide details about what is being predicted, and (2) the two **"model output representation"** columns specify the type of prediction, and identifying information about that prediction. Finally, (3) the **value** column provides the model output of the prediction. | |
| Per hubverse convention, **there are two groups of columns for model output**[^model-id] followed by a single column for values. Each group of columns serves a specific purpose: (1) the **"task ID"** columns provide details about what is being predicted, and (2) the two **"model output representation"** columns specify the type of prediction and identifying information about that prediction. Finally, (3) the **value** column provides the model output of the prediction. |
There was a problem hiding this comment.
From my understanding of #201, the column for model output is the column for values (the others are "metadata about the representation of that output"). I phrased it differently in my most recent commit.
zkamvar
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #201