Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify missingness of point estimates; add examples for determining output_type_id format #197

Merged
merged 21 commits into from
Oct 31, 2024
Merged

clarify missingness of point estimates; add examples for determining output_type_id format #197

merged 21 commits into from
Oct 31, 2024

Commits on Oct 21, 2024

  1. modify model output chapter to indicate that missingness is required … 

    …for the schema
    @zkamvar
    zkamvar committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    904d017 View commit details
    Browse the repository at this point in the history

  2. add NA explanation in quickstart

    @zkamvar
    zkamvar committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a83275e View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. rework output_type_id discussion

    @zkamvar
    zkamvar committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    60b2ee7 View commit details
    Browse the repository at this point in the history

  2. update language

    @zkamvar
    zkamvar committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5308cd5 View commit details
    Browse the repository at this point in the history

  3. add more details and fix links

    @zkamvar
    zkamvar committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    030de5b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alvaro J. Castro Rivadeneira <[email protected]>
    @zkamvar @micokoch
    zkamvar and micokoch authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f26c129 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into znk/clarify-missingness

    @zkamvar
    zkamvar authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    943bfe6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Anna Krystalli <[email protected]>
    @zkamvar @annakrystalli
    zkamvar and annakrystalli authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f4eb77c View commit details
    Browse the repository at this point in the history

  3. change model_out_tbl to model_out 

    This to avoid confusion with the `model_out_tbl` class that is the
output of `connect_hub()`
    @zkamvar
    zkamvar committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a1976f7 View commit details
    Browse the repository at this point in the history

  4. add more code and context for getting example data 

    I iterated on Anna's comment about using `hubData::create_hub_schema()`
and `hubValidations::submission_tmpl()` and created examples that would
work for them.

There is still the missing information about installing packages, but we
can burn that bridge when we get there.
    @zkamvar
    zkamvar committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    11b00c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Anna Krystalli <[email protected]>
    @zkamvar @annakrystalli
    zkamvar and annakrystalli authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aaeec18 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Becky Sweger <[email protected]>
Co-authored-by: Anna Krystalli <[email protected]>
    @zkamvar @bsweger @annakrystalli
    3 people authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2716974 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Becky Sweger <[email protected]>
    @zkamvar @bsweger
    zkamvar and bsweger authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fd39624 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Lucie Contamin <[email protected]>
    @zkamvar @LucieContamin
    zkamvar and LucieContamin authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    56b1326 View commit details
    Browse the repository at this point in the history

  5. change smart quotes to ASCII

    @zkamvar
    zkamvar committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    26104d3 View commit details
    Browse the repository at this point in the history

  6. make model_id consistent

    @zkamvar
    zkamvar committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9692c5c View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Becky Sweger <[email protected]>
    @zkamvar @bsweger
    zkamvar and bsweger authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3556918 View commit details
    Browse the repository at this point in the history

  8. move demo of template and schema to examples 

    Based on feedback in
https://github.com/hubverse-org/hubDocs/pull/197/files#r1822764075,

It made more sense to put these directly in the examples.
    @zkamvar
    zkamvar committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5a117d1 View commit details
    Browse the repository at this point in the history

  9. add more emph

    @zkamvar
    zkamvar committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1941004 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Anna Krystalli <[email protected]>
Co-authored-by: Lucie Contamin <[email protected]>
    @zkamvar @annakrystalli @LucieContamin
    3 people authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7870e9e View commit details
    Browse the repository at this point in the history

  2. move coerce_to_hub_schema() to the R section; add 🐍 context 

    It made more sense for this function to be what you would use before
writing out the schema to parquet in R. It doesn't really do much for
Python folks because they aren't likely to go through R to submit their
models.
    @zkamvar
    zkamvar committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    128fdcd View commit details
    Browse the repository at this point in the history