Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove use of warden and use omniauth-github in preparation for supporting GitLab #157

Closed
wants to merge 1 commit into from

Conversation

stanhu
Copy link

@stanhu stanhu commented Dec 18, 2015

Relates to huboard/ghee#37.

@rauhryan
Copy link
Member

Hmmm interesting

I will have to dig into this a little bit more when I have time.

I ran into some problems with warden, specifically warden-github and it boiled down to SSL issues

Also, I'm not sure how we are going to support GitLab right now.

If HuBoard should be one app or if it's completely separate "builds" of HuBoard and we have something like gitlab.huboard.com and possible github.huboard.com and so one

That's actually pretty interesting, I kind of like that idea, huboard.com could move to static site that's kind of like a train switch to the different subdomains.

Would love to hear some thoughts on that...

@rauhryan
Copy link
Member

@stanhu I am actively looking into this right now.

Proper OAuth flow is way more complex than I thought.

Just want to let you know that we didn't forget about you.

Let me know if you have some free time to skype or chat about how we want to move forward with this PR

Cheers,

  • Ryan

@discorick discorick mentioned this pull request Mar 3, 2016
3 tasks
@stanhu
Copy link
Author

stanhu commented Mar 20, 2016

@rauhryan Somehow I missed this. Sure, maybe we can discuss this this week.

@dahlbyk
Copy link
Member

dahlbyk commented Mar 20, 2016

Fortunately, some of the complexity to which @rauhryan was referring was due to a quirk in GitHub public_repo/repo behavior that seems to have been resolved (see #172 (comment)).

Also FYI, #214 adds some OAuth complexity to support deploying review apps. We'll need to implement equivalent behavior with OmniAuth.

@discorick
Copy link
Member

Closing as HuBoard for GitLab is no longer in development.

@discorick discorick closed this Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants