Austenem/CAT-1052 Add bulk download dialog to detail pages #3622
+78
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Nov 26, 2024
|
|
||
| function OutlinedButton({ children, ...rest }: OutlinedButtonProps) { | ||
| return ( | ||
| <StyledButton variant="outlined" {...rest}> |
There was a problem hiding this comment.
Not sure we need to introduce a new shared component to pass a single prop. @NickAkhmetov thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add bulk file download option to the Bulk Download section of dataset detail pages.
Design Documentation/Original Tickets
CAT-1052 Jira ticket
Testing
Tested starting the dialog from detail pages with no processed datasets and with multiple datasets.
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.