-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NickAkhmetov/HMP-180 Cell types landing page first pass #3130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading states, display related dataset UUID's in modal
Closing in favor of #3246 given how stale this implementation is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the implementation of the cell types landing page; this mainly only covers display-related aspects, and relies on some pretty loud usage of the cells/ontology API's since most of the table data can only be fetched for one term at a time.
It seemed like a logical pause point to open the PR here to identify any issues before implementing the more complex features
routes_cell_types.py
for cell-types related endpoints/cell-types/list.json
-> list of cell names provided by cells api/cell-types/<cell_type>/description.json
,/cell-types/<cell_type>/organs.json
,/cell-types/<cell_type>/datasets.json
look up the respective information for a single cell type/cell-types/<cell_type>/assays.json
is a placeholder for the "data types" lookupview datasets
button is clicked, dialog pops up with list of dataset UUIDs that link to the appropriatebrowse/dataset/${uuid}
linkMisc fixes:
ResultsTable
now has one tbody per table instead of one for each rowprovtable
imports comment that was popping up in every PR as an automatic commentFull page screenshot: