update metadata, histogram, visualization, violin plot modules component #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 306694e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
🚀 Preview Deploy Report Updated✅ Successfully deployed preview here |
LibbyUX
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Hey Bhushan! Thanks so much for the quick work on this: I love the smoothness of the interactions for showing/hiding the unknown metadata and expanding/collapsing the metadata panel.
A couple of questions:
- Is it possible to implement the icon button micro tooltips for expand/collapse + more?
- Is it possible to use the basic text button for the top two metadata entries in the sample visualizations?
Looking so good! Thanks for all!
bhushankhope
changed the title
LibbyUX
reviewed
Oct 9, 2024
bhushankhope
changed the title
…into metadata-module
Merged
|
axdanbol
added a commit
that referenced
this pull request
Nov 18, 2024
* Add violin plots by type * Improvements to violin plot * Update violin plot upload settings * Improvements * Refactor visualizations * Testing * Upload Data module updates * Upload Data style updates * Add column header checking * Add configure parameters card + styling updates * Color map selection updates * Fix validation of inputs * Move column header errors to step 2; styling improvements * Remove unused code * Set headers in submitted data to selected values * Fix cell types check * Fix broken tests * Increase testing and doc coverage * Fix test * Fix sonarcloud issues * Add ontologyId to submitted data * Add unified letter casing for headers; add headers to edge csv file downloads * Renaming and tweaks * Renaming * Set up design system theming * update cell type component * update path of main in cde lib project.json * update theme * Change create vis page styles to use design system * add links count to cell type table * More style updates * Make styles closer to spec * Remove redundant assets * add toggle links column functionality * compute columns based on the links visibility signal * fix toggle signal for cell links * fix tests for downloads * update snackbar timer * add noreferrer to link * add micro tooltip to cell types module * update padding and selected color for button toggle * Rename edge headers * Remove lodash * create expansion panel * add animation to expansion panel * update peer deps * improve test coverage * add height check in tests for expansion panel * update icon button size and styles in the design system * update design file in the icon button stories * refactor animation code * Cde nav header updates (#778) * Update app logos component * Add sidenav to nav header and update landing page * Add product logos to design system * Update nav header with product logo DS component * Rename App Logos to Nav Header Buttons * Add software status indicator * Updates to nav header components * Small changes to nav header styles * Adjust header styling * Remove duplication * Software status indicator updates * Updates to sidenav demo * Sidenav updates * Tweaks * Testing and documentation * Fix testing * Node dist vis (#758) * initial setup of library + wc in apps * create services for nodes and edges * refactor node data service * update peer dependencies * create deck gl visualization component * update peer deps * improve doc coverage * refactor: Node dist vis data format update (WIP) * refactor: lint fix * refactor(node-dist-vis): Remove export * feat(lib:common): Create library 'common' * refactor(lib:common): Move file loaders into 'common/fs' * refactor(node-dist-vis): Implement data loading * chore: Lint fix * refactor(node-dist-vis): ⚰️ Remove unused data services * refactor(node-dist-vis): Add mode logic (WIP), improve filters (WIP), & tweaks * refactor(node-dist-vis): Implement improved node filtering & minor fixes * fix(node-dist-vis): Fix edge filtering bug * test(node-dist-vis): Remove test files until jest + deck.gl is figured out * test(cde-visualization): Fix a couple of imports * refactor(node-dist-vis): Cleanup & code smell fixes * refactor(node-dist-vis): 📝 Add documentation & minor type and error handling tweaks * refactor(node-dist-vis): Remove test data --------- Co-authored-by: Daniel Bolin <[email protected]> * Remove size option and adjust spacing in breadcrumbs (#789) * Remove size option and adjust spacing in breadcrumbs * Remove disableRipple * Cde design system (#773) * Use design system for cde-visualization * Update landing page to use design system * More style updates for tooltips and visualization page * Change violin vis size * Fix build issue * Update testing * Tweaks * Use error indicator component in design system * Add delete file button to design system and cde * Remove export * Fix bugs in file upload * Add workflow card to design system and cde * Add load progress bar to workflow cards * Remove commented out code * Improve progress bar * Tweaks * Update tests * Create info modal component with two variants (#794) * Create info modal component with two variants * Use mat icon button for close icon * Add doc coverage; width adjustments * Aria label * Design system menu updates (#793) * Remove menu size option and update menu button states * Button tweaks * Remove unused import * Build improvements (#796) * build(node-dist-vis): 🏗️ Disable chunk splitting in build, remove zone, and bundle scripts and workers in build-webcomponent step * build(cde): 🏗️ Update build configuration * fix: Fix resolve path in bundle-scripts.mjs * Update styles for tree nodes and buttons (#797) * Cde improvements (#799) * Change cde logo home link to '/' * Fix background colors on visualization page * Disable Organize Data and Configure Parameters until data set uploaded * Fix HRA logo width in header (Firefox) * update metadata, histogram, visualization, violin plot modules component (#772) * update metadata module * add micro tooltip to metadata * update histogram component * update grid size and histogram * update visualization menu * fix imports * update css for vis page and its modules * fix tests for cell types module * improve test coverage for cde-vis lib * add dialog for fullscreen * fix test for fullscreen component * improve doc coverage for full screen component * improve test coverage * fix histogram header css * use custom expansion panel in the histogram * use expansion panel in sample metadata * use expansion panel for cell types module * use expansion panel in cell types and violin graph * use fullscreen for all modules on vis page * use expansion panel and fullscreen portal for visualization module on vis page * update logic for fullscreen dialog * fix visualization height in expansion panel * fix overflowing of content in expansion panel * fix scrolling of cell types and violin plot * minor fixes to vis page * fix height issue of node dist vis * fix histogram resizing in fullscreen mode * remove svg renderer from downloads for histogram * fix imports * update violin plot config * write tests for tree size directive * write test for select size directive * fix scrollbar position in violin component * fix histogram all cells color picker * fix violin container width * add histogram menu component * create violin menu component * fix color picker tooltip * fix css block * improve design system test coverage * improve cde-vis test coverage * improve doc coverage * Update text field appearance (#802) * Update text field appearance * Add validation to storybook inputs; Change error state color * Node dist vis integration (#798) * refactor(node-dist-vis): 🚚 Move models into a secondary entrypoint * refactor(cde-visualization): Initial node-dist-vis integration (WIP) * refactor(cde-visualization): Update peer deps * build: ⬆️ Upgrade ngxtension (for bug fixes) * build: Update the target of builds and libs to es2022 * feat(node-dist-vis): Implement default generators for edges & colors when not provided as inputs * refactor(node-dist-vis): Improve inputs/outputs & minor tweaks * refactor(cde-visualization): Cleaning up cde (WIP) * refactor(node-dist-vis): Tweak default color map colors * refactor(node-dist-vis): Add edgesDisabled input & other minor tweaks * feat(webcomponents): Expose a reference to the angular component on custom elements * refactor(cde-visualization): Clean up cde's node-dist-visualization component * feat(node-dist-vis): ✨ Implement selection layer * fix(node-dist-vis): Fix node picking and add target to edges * refactor(node-dist-vis): Tweak selection layer * refactor(node-dist-vis): Improve edge filtering * refactor(cde-visualization): Connect node-dist-vis events * refactor(cde-visualization): Reimplement csv downloading & tweak filter logic * fix: Fix builds * refactor(cde-visualization): Remove build-webcomponent target (not applicable to a library) * refactor(node-dist-vis): Update node selection to handle deep picking * refactor(cde-visualization): Cleanup some attributes and bindings * refactor(cde-visualization): Connect cell type selection back to node dist vis * feat(cde-visualization): Implement info modal for dist in inpect mode * fix(cde-visualization): Filter nodes/edges/colormap on download * refactor(node-dist-vis): 🔥 Remove dead code * refactor(design-system): Tweaks (misspelling/exports/styling) * refactor(cde-visualization): Reset rotation when switching to select mode * test(cde-visualization): Node visualization tests * refactor(cde-visualization): ⚰️ Remove dead code * test(cde-visualization): ✅ Fix multiple tests (coverage WIP) * refactor(cde): Fix data format from create page * test(cde): ✅ Fix tests for cde-ui * refactor(cde): Moved shared data into json file * test(cde-visualization): Improve testing * fix(cde-visualization): Fix sizing of visualization * test(cde-visualization): ✅ Increase test coverage * test(cde-visualization): Even more test coverage * Test coverage * Test coverage --------- Co-authored-by: edlu77 <[email protected]> * Sort violin plot by cell count (#808) * refactor(node-dist-vis): 🚚 Move models into a secondary entrypoint * refactor(cde-visualization): Initial node-dist-vis integration (WIP) * refactor(cde-visualization): Update peer deps * build: ⬆️ Upgrade ngxtension (for bug fixes) * build: Update the target of builds and libs to es2022 * feat(node-dist-vis): Implement default generators for edges & colors when not provided as inputs * refactor(node-dist-vis): Improve inputs/outputs & minor tweaks * refactor(cde-visualization): Cleaning up cde (WIP) * refactor(node-dist-vis): Tweak default color map colors * refactor(node-dist-vis): Add edgesDisabled input & other minor tweaks * feat(webcomponents): Expose a reference to the angular component on custom elements * refactor(cde-visualization): Clean up cde's node-dist-visualization component * Sort violin plot by cell count * feat(node-dist-vis): ✨ Implement selection layer * fix(node-dist-vis): Fix node picking and add target to edges * refactor(node-dist-vis): Tweak selection layer * refactor(node-dist-vis): Improve edge filtering * refactor(cde-visualization): Connect node-dist-vis events * refactor(cde-visualization): Reimplement csv downloading & tweak filter logic * fix: Fix builds * refactor(cde-visualization): Remove build-webcomponent target (not applicable to a library) * refactor(node-dist-vis): Update node selection to handle deep picking * refactor(cde-visualization): Cleanup some attributes and bindings * refactor(cde-visualization): Connect cell type selection back to node dist vis * feat(cde-visualization): Implement info modal for dist in inpect mode * fix(cde-visualization): Filter nodes/edges/colormap on download * refactor(node-dist-vis): 🔥 Remove dead code * refactor(design-system): Tweaks (misspelling/exports/styling) * refactor(cde-visualization): Reset rotation when switching to select mode * test(cde-visualization): Node visualization tests * refactor(cde-visualization): ⚰️ Remove dead code * test(cde-visualization): ✅ Fix multiple tests (coverage WIP) * refactor(cde): Fix data format from create page * test(cde): ✅ Fix tests for cde-ui * refactor(cde): Moved shared data into json file * test(cde-visualization): Improve testing * fix(cde-visualization): Fix sizing of visualization * test(cde-visualization): ✅ Increase test coverage * test(cde-visualization): Even more test coverage --------- Co-authored-by: Daniel Bolin <[email protected]> --------- Co-authored-by: edlu77 <[email protected]> Co-authored-by: Bhushan Khope <[email protected]> Co-authored-by: Edward Lu <[email protected]> Co-authored-by: Bhushan Khope <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the metadata & histogram component on the cde vis page according to current spec