Fix error handling on StreamTrait::getContents() method (#28)

httpsoft · Nov 15, 2023 · d3ea2e3 · d3ea2e3
1 parent 6c3352c
commit d3ea2e3
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/src/StreamTrait.php b/src/StreamTrait.php
@@ -8,7 +8,6 @@
 use RuntimeException;
 use Throwable;
 
-use function array_key_exists;
 use function fclose;
 use function feof;
 use function fopen;
@@ -322,16 +321,23 @@ public function read($length): string
      *
      * @return string
      * @throws RuntimeException if unable to read or an error occurs while reading.
-     * @psalm-suppress PossiblyNullArgument
      */
     public function getContents(): string
     {
+        if (!$this->resource) {
+            throw new RuntimeException('No resource available. Cannot read.');
+        }
+
         if (!$this->isReadable()) {
             throw new RuntimeException('Stream is not readable.');
         }
 
-        if (($result = stream_get_contents($this->resource)) === false) {
-            throw new RuntimeException('Error reading stream.');
+        try {
+            if (($result = stream_get_contents($this->resource)) === false) {
+                throw new RuntimeException('Stream is detached.');
+            }
+        } catch (Throwable $e) {
+            throw new RuntimeException('Unable to read stream contents: ' . $e->getMessage());
         }
 
         return $result;
@@ -359,18 +365,14 @@ public function getMetadata($key = null)
             $metadata = stream_get_meta_data($this->resource);
         } catch (Throwable $e) {
             $this->detach();
-            throw new RuntimeException('Unable to read stream contents: ' . $e->getMessage());
+            return $key ? null : [];
         }
 
         if ($key === null) {
             return $metadata;
         }
 
-        if (array_key_exists($key, $metadata)) {
-            return $metadata[$key];
-        }
-
-        return null;
+        return $metadata[$key] ?? null;
     }
 
     /**