raise HTTP::Request::InvalidURIError for wrong url's #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixti
reviewed
Aug 14, 2022
Comment on lines
+157
to
+158
| rescue Addressable::URI::InvalidURIError => e | ||
| raise HTTP::Request::InvalidURIError, e.message |
There was a problem hiding this comment.
I wonder if we should move this to HTTP::URI.parse instead? And probably call it HTTP::URI::InvalidError
ixti
reviewed
Aug 14, 2022
Comment on lines
+228
to
+230
| raise(InvalidURIError, "empty uri provided") if @uri.host.nil? | ||
| raise(UnsupportedMethodError, "unknown method: #{verb}") unless METHODS.include?(@verb) | ||
| raise(UnsupportedSchemeError, "unknown scheme: #{scheme}") unless SCHEMES.include?(@scheme) |
There was a problem hiding this comment.
IMO, all of the above should raise ArgumentError. Please make this method private. Furthermore, what are your thoughts on renaming it to validate!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really enjoy using your gem, so decided to study internal of it better.
is there any better way to understand internals, when contributing to gem directly? I guess, not.
This PR addressed an issue that is assigned for 5.0 milestone
closes #565