-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable user name lookup in static builds against glibc #1527
Draft
cgzones
wants to merge
1
commit into
htop-dev:main
Choose a base branch
from
cgzones:static_glibc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static linking against glibc might crash due to usage of NSS modules, e.g. via getpwuid() (see htop-dev#503). The linker also warns about it: warning: Using 'getpwuid' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
BenBE
added
enhancement
Extension or improvement to existing feature
build system 🔧
Affects the build system rather then the user experience
labels
Aug 24, 2024
BenBE
approved these changes
Aug 24, 2024
@cgzones Anything still missing here? |
There might be still hidden usage of NSS modules, e.g. a static build reports:
Maybe it's best to recommend not using static builds on Linux against glibc? |
Can we check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build system 🔧
Affects the build system rather then the user experience
enhancement
Extension or improvement to existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static linking against glibc might crash due to usage of NSS modules, e.g. via getpwuid() (see #503).
The linker also warns about it: