Fix the logic for validating current value by step #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only works with integer steps, and does not account that modulo operator fails with `0.1` as the 2nd parameter. The `fmod` also fails, by returning non-zero when `0` is expected. Explanation: https://stackoverflow.com/questions/3148937/compare-floats-in-php https://stackoverflow.com/questions/32996034/fmod-returning-incorrect-result
Go back to basics - convert the number to string, and check if it contains decimal point. This seems to be the safest way to prove the number is integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code only works with integer steps, and does not account that modulo operator fails with
0.1as the 2nd parameter.The
fmodalso fails, by returning non-zero when0is expected.Explanation:
https://stackoverflow.com/questions/3148937/compare-floats-in-php
https://stackoverflow.com/questions/32996034/fmod-returning-incorrect-result