Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-1968: Warn about old job router configuration syntax depreca… #581

Conversation

ColeBollig
Copy link
Contributor

…tion

-Added warning message to all provided configuration files
at the use of one of the deprecated macros
-In verify_ce_config.py if using the old configuration display
warning message

…tion

-Added warning message to all provided configuration files
 at the use of one of the deprecated macros
-In verify_ce_config.py if using the old configuration display
 warning message
Copy link
Collaborator

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. See in-line comments. Pre-approving

config/01-ce-router-defaults.conf Outdated Show resolved Hide resolved
src/verify_ce_config.py Outdated Show resolved Hide resolved
src/verify_ce_config.py Outdated Show resolved Hide resolved
@ColeBollig
Copy link
Contributor Author

Here are those minor anticipated changes.

src/verify_ce_config.py Outdated Show resolved Hide resolved
Expand message for job router syntax deprecation to be more inclusive to the entirety of the HTCSS.

Co-authored-by: Brian Lin <[email protected]>
Copy link
Collaborator

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColeBollig
Copy link
Contributor Author

@timtheisen said that the EL8 test failures are not related to the given changes so I will merge this

@ColeBollig ColeBollig merged commit 5f40db7 into htcondor:V6-branch Sep 8, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants