Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand for Hightouch #1

Merged
merged 53 commits into from
Mar 22, 2024
Merged

Rebrand for Hightouch #1

merged 53 commits into from
Mar 22, 2024

Conversation

narciero
Copy link
Contributor

@narciero narciero commented Mar 14, 2024

Refactor of consent-manager to integrate with Hightouch Events Browser SDK. The key changes are:

  • Removal of remote destination loading. For now, users will just consent to generic tracking categories (ie. "Functional", "Marketing", "Advertising", etc).
  • Emit a Consent Updated on preference changes (in addition to identify event)
  • More sensible defaults to make adoption as simple as possible

@narciero narciero changed the title Rebrand Rebrand for Hightouch Mar 21, 2024
@narciero narciero requested review from kklin and NickStefan and removed request for kklin March 21, 2024 16:14
@narciero
Copy link
Contributor Author

@kklin @NickStefan For review, feel free to just focus on the stuff inside /src (primarily the logic in /src/consent-manager-builder). A lot of the changes are around storybook/testing so no need to waste time there. Thanks!

@narciero narciero requested review from kklin and removed request for NickStefan March 21, 2024 16:34
Copy link

@NickStefan NickStefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I had some questions

package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/consent-manager/container.tsx Show resolved Hide resolved
src/consent-manager/preference-dialog.tsx Show resolved Hide resolved
@narciero narciero merged commit 48d2140 into main Mar 22, 2024
1 check passed
@narciero narciero deleted the narciero/rebrand branch March 22, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants