Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration taken to pay invoice #1091

Merged
merged 8 commits into from
Dec 15, 2022
Merged

Add duration taken to pay invoice #1091

merged 8 commits into from
Dec 15, 2022

Conversation

niteshbalusu11
Copy link
Collaborator

#1072

Added duration taken to pay an invoice and keysend.

@vercel
Copy link

vercel bot commented Dec 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
blixt-wallet ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 9:49PM (UTC)

hsjoberg
hsjoberg requested changes Dec 8, 2022
View reviewed changes
Copy link
Owner

@hsjoberg hsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please change duration to be a number (REAL in SQL) instead of a string and save the data in the milliseconds instead.

src/storage/database/transaction.ts Outdated Show resolved Hide resolved
@hsjoberg
Copy link
Owner

hsjoberg commented Dec 8, 2022

For some reason web blixt does not work as seen by trying Vercel above.
Difficult to get error from the production build here but maybe you can try yarn web locally and check what's up.

@niteshbalusu11
Copy link
Collaborator Author

For some reason web blixt does not work as seen by trying Vercel above. Difficult to get error from the production build here but maybe you can try yarn web locally and check what's up.

ok, will look.

@niteshbalusu11 niteshbalusu11 force-pushed the add-time-taken-to-pay-invoice branch from 5929b36 to 2201aa7 Compare December 8, 2022 16:42
@niteshbalusu11
Copy link
Collaborator Author

Hmm, web version just fails to load. I don't see any errors in logs or browser console. Not understanding what's going on.

hsjoberg
hsjoberg requested changes Dec 13, 2022
View reviewed changes
Copy link
Owner

@hsjoberg hsjoberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just one little thing

src/windows/TransactionDetails.tsx Outdated Show resolved Hide resolved
@niteshbalusu11 @hsjoberg
Fix duration to 2 decimal places
04d2563 
Co-authored-by: Hampus Sjöberg <[email protected]>
@hsjoberg
Copy link
Owner

LGTM! 💯

@hsjoberg hsjoberg merged commit 60154cf into hsjoberg:master Dec 15, 2022
@niteshbalusu11 niteshbalusu11 deleted the add-time-taken-to-pay-invoice branch December 15, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsjoberg hsjoberg hsjoberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niteshbalusu11 @hsjoberg