Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve various warnings #35

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Resolve various warnings #35

merged 2 commits into from
Dec 20, 2023

Conversation

ariostas
Copy link
Member

@ariostas ariostas commented Dec 19, 2023

I fixed a bunch of different warnings including the ones from #18 and #19. Also fixed a warning for an unused import in footer.js, the hsf logo not being square, and useEffect having a missing dependency. Also fixed the typos mentioned in #32. Lastly, I modified the iris-hep svg file to more closely match the HSF one and since the clickable area used to be huge.

The last remaining warning I get is this one, which was also mentioned in #21. But I think it might be trickier to fix it since it's coming from other dependencies.

warn `isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
    at isModuleDeclaration (/Users/ariostas/Documents/HSF-training/training-center-aniket/node_modules/@babel/types/lib/validators/generated/index.js:2748:35)
    at PluginPass.Program (/Users/ariostas/Documents/HSF-training/training-center-aniket/node_modules/babel-plugin-lodash/lib/index.js:102:44)

Closes #18
Closes #19
Closes #32

@klieret klieret self-requested a review December 20, 2023 17:16
@klieret
Copy link
Member

klieret commented Dec 20, 2023

Thanks so much, that's a lot of things in one PR!

@klieret klieret merged commit 896dab7 into main Dec 20, 2023
1 check passed
@klieret klieret deleted the fix-warnings branch December 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos: Curicula === vs == x is assigned a value but never used
2 participants