Update latest sdkv3 #65
Conversation
| $token = new HpsTokenData(); | ||
| $token->tokenValue = ($response != null | ||
| ? $response->token_value | ||
| : ''); |
There was a problem hiding this comment.
Moving this into buildCardHolder and not renaming the method/variable is confusing from a maintenance perspective.
classes/class-gf-securesubmit.php
Outdated
| ->withCurrency($currency) | ||
| ->withAddress($address) | ||
| ->withAllowDuplicates(true) | ||
| ->execute(); |
There was a problem hiding this comment.
The data within $secureEcommerce and the level II / corporate purchasing card flag ($cpcReq) are no long included in the original authorization request.
There was a problem hiding this comment.
@pkuma525 I may not have conveyed the right meaning here. The $secureEcommerce and $cpcReq values can still be used in the new SDK, but your original changes did not add these values to the authorization builder, causing them to not be included in the request to the gateway. We need both to be included in the gateway request to leverage both programs.
classes/class-gf-securesubmit.php
Outdated
| ->withCurrency($currency) | ||
| ->withAddress($address) | ||
| ->withAllowDuplicates(true) | ||
| ->execute(); |
There was a problem hiding this comment.
The data within $secureEcommerce and the level II / corporate purchasing card flag ($cpcReq) are no long included in the original authorization request.
There was a problem hiding this comment.
@pkuma525 I may not have conveyed the right meaning here. The $secureEcommerce and $cpcReq values can still be used in the new SDK, but your original changes did not add these values to the authorization builder, causing them to not be included in the request to the gateway. We need both to be included in the gateway request to leverage both programs.
There was a problem hiding this comment.
Let's rename buildCardHolder and buildCheckHolder and make sure they're being used correctly. The new SDK doesn't have a notion of a card/check holder object as this data now lives on either the payment data object (CreditCardData or ECheck) or on the Address object. We also need to ensure that the correct payment data object is being used to initiate the transaction.
classes/class-gf-securesubmit.php
Outdated
| @@ -1688,9 +1678,9 @@ private function buildCardHolder($feed, $submission_data, $entry) | |||
| */ | |||
| private function buildCheckHolder($feed, $submission_data, $entry) | |||
| { | |||
| $checkHolder = new HpsCheckHolder(); | |||
| $checkHolder = new ECheck(); | |||
| $checkHolder->address = $this->buildAddress($feed, $submission_data, $entry); | |||
There was a problem hiding this comment.
There should not be an address property on ECheck, so this line can be removed once the address is added to the authorization builder for check transactions.
classes/class-gf-securesubmit.php
Outdated
| $checkHolder->address = $this->buildAddress($feed, $submission_data, $entry); | ||
| $checkHolder->checkName = htmlspecialchars(rgar($submission_data, 'ach_check_holder')); //'check holder'; | ||
| $checkHolder->checkHolderName = htmlspecialchars(rgar($submission_data, 'ach_check_holder')); //'check holder'; |
There was a problem hiding this comment.
This should still be checkName. The checkHolderName property isn't mapped to the correct gateway field.
classes/class-gf-securesubmit.php
Outdated
| $config->versionNumber = '1916';*/ | ||
| $config = new ServicesConfig(); | ||
| $config->secretApiKey = $key; | ||
| $config->serviceUrl = "https://cert.api2.heartlandportico.com"; |
There was a problem hiding this comment.
The configuration needs to support production as well. We can check the key to determine which environment should be used.
…ms-addon into update-latest-sdkv3
updated the code to latest sdk for credit card payment and check payment