Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages & popups refactoring #267

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Pages & popups refactoring #267

wants to merge 11 commits into from

Conversation

ai
Copy link
Contributor

@ai ai commented Oct 18, 2024

No description provided.

Copy link
Contributor

Pull request auto-reviewer

  • Think about code testing.

  • Think about moving code to core/. What code will also be useful on other platforms?

  • Think about HTML semantics.

  • Think about accessibility. Try to search for a11y recommendations for your case. Think about how screen reader users will use the tool. Is it easy to use on a screen with bad contrast?

  • The UI was checked in Chrome and Firefox (and Safari or Epiphany if you have them).

  • Think about making types more precise. Can you better explain data relations by type?

@github-actions github-actions bot temporarily deployed to preview-267 October 18, 2024 23:57 Destroyed
Copy link
Contributor

Pull request auto-reviewer

  • Don’t rush. Check all changes in PR again.

  • Run pnpm test.

  • Think about changing documentation.

    • If you added a script to scripts/, add a comment with a description.
    • If you added a new folder, add its description to the project’s README.md.
    • If you added config, describe how we use this tool in the config’s comment.
    • Try to focus on “why?”, not “how?”.
  • If you added a new dependency, check our requirements.

@github-actions github-actions bot temporarily deployed to preview-267 October 19, 2024 21:36 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 19, 2024 22:52 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 20, 2024 22:00 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 21, 2024 22:53 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 21, 2024 23:04 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 26, 2024 23:31 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 October 29, 2024 05:20 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 November 5, 2024 00:16 Destroyed
@github-actions github-actions bot temporarily deployed to preview-267 November 5, 2024 00:29 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant