Handle new treatment progress type noTreatment #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenscreen23
requested changes
May 8, 2023
Co-authored-by: Lukas Hagen <[email protected]>
Greenscreen23
approved these changes
May 8, 2023
lukasrad02
deleted the
fix/948-handle-new-treatment-progress-type-notreatment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By merging this PR, there won't be any radiograms informing the trainees that a simulated region lost it's leader, since the treatment status
noTreatmentis not reported. However, this radiogram carried the information about a missing leader implicitly only. For a reliable report of the leader leaving their region, the reports behavior should handle leader change events instead. #949 is meant to keep track of this.PR Checklist
Please make sure to fulfill the following conditions before marking this PR ready for review:
[ ] If this PR adds new actions or other ways to alter the state, test scenarios have been addedNot applicable