Added fix for 704 #727
Merged
Added fix for 704 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi |
sneharai4
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
@bhagyashree-sarawate Code changes looks good to me. Could you please attach the tests for this where I can see the expected results in docker volume inspect command.
sneharai4
reviewed
Aug 26, 2019
hpedockerplugin/volume_manager.py
Outdated
| diff_hour = diff.seconds / 3600 | ||
| return diff_hour | ||
| diff_hour = diff.total_seconds() / 3600 | ||
| return round(diff_hour) |
PFA output for the bug 704 which include import and inspect of a snapshot |
sneharai4
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #704