Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Cleaning up the CLI mess stack #97

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

itkovian
Copy link
Member

@itkovian itkovian commented Jan 7, 2025

Move code to a new stack such that we can ditch a lot of obsolete code that was once introduced to deal with py 2.[47] shortcomings.

  • introduce mixins so derived classes can choose what features to use (timestamps, locks, nagios blah blah, ...)
  • allow moving to ConfigArgParse while keeping compatibility with existing code
  • fix the parsing of configfiles and spit into multiple arguments for ConfigArgParse
  • check if we need the post method
  • fix the nagios stats thing so I becomes usable in the new stack

@itkovian itkovian marked this pull request as draft January 7, 2025 15:31
@itkovian itkovian force-pushed the split-nrpe-convenience-methods branch from 5c9dbb0 to 076ce72 Compare January 16, 2025 14:36
@itkovian itkovian marked this pull request as ready for review January 16, 2025 14:38
@itkovian
Copy link
Member Author

This is ready for a review, but should not yet be merged.

@itkovian itkovian requested a review from wdpypere January 16, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant