New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormun]: Fix request_datetime in ridesharing #4321

Open

kadhikari wants to merge 2 commits into dev from fix_ridesharing_request_date

Contributor

kadhikari commented Nov 15, 2024 •

edited

Loading

We use a tuple structure PeriodRxtremity('datetime', 'represents_start') to keep departure and arrival date_time.
Except InstantSystem, all the other ridesharing services do not have parameter wanted arrival date_time hence error is present for all of them.
The new structure RequestDates ('departure_datetime', 'arrival_datetime', 'represents_start') should be enough to manage all the ridesharing services (PeriodRxtremity should not be modified as it is used by other components also).

Ticket: https://navitia.atlassian.net/browse/NAV-3506

kadhikari added 2 commits

November 15, 2024 17:32


          [jormun]: Fix request_datetime in ridesharing

5e9a86d


          Formatting 1

dd86b1d

sonarcloud bot commented Nov 15, 2024

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kadhikari requested review from SGrenet, adrien3d, azime and xlqian

November 18, 2024 09:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet