Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormun]: Add ODT in all PT conditions #4308

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[jormun]: Add ODT in all PT conditions #4308

merged 3 commits into from
Oct 1, 2024

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Sep 30, 2024 •
edited
Loading

Before the feature virtual ODT:

  • kraken and loki used to send section type PT but not ODT in the response proto to jormun / gormun
  • jormun / gormun transform PT to ODT if the start or end of the section is of ODT during serializing (last action).
  • All the filters as well as comparison conditions are on PT (without ODT)

After the feature:

  • loki send a section type PT as well as ODT.
  • we should add ODT in all filters as well as comparison conditions on PT

For more details: https://navitia.atlassian.net/browse/NAV-3378

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kadhikari kadhikari merged commit 8a41c97 into dev Oct 1, 2024
8 of 9 checks passed
@kadhikari kadhikari deleted the fix_all_comparison_with_pt branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrenet SGrenet SGrenet approved these changes

@xlqian xlqian xlqian approved these changes

@adrien3d adrien3d adrien3d approved these changes

@azime azime Awaiting requested review from azime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @adrien3d @xlqian @SGrenet