[jormungandr] Init connector Forseti for bss stations #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
reviewed
Sep 15, 2023
source/tyr/migrations/versions/cab8323f71bd_add_bss_stations_in_navitia_service_type.py
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/parking_places_manager.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/parking_places_manager.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/tests/forseti_test.py
Outdated
Show resolved
Hide resolved
added 2 commits
September 15, 2023 17:05
pbougue
approved these changes
Sep 18, 2023
xlqian
approved these changes
Sep 18, 2023
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/parking_space_availability/bss/forseti.py
Outdated
Show resolved
Hide resolved
Comment on lines
+137
to
+142
| if not data: | ||
| return Stands(0, 0, StandsStatus.unavailable) | ||
| obj_stations = data.get('stations', []) | ||
|
|
||
| if not obj_stations: | ||
| return Stands(0, 0, StandsStatus.unavailable) |
There was a problem hiding this comment.
Suggested change
| if not data: | |
| return Stands(0, 0, StandsStatus.unavailable) | |
| obj_stations = data.get('stations', []) | |
| if not obj_stations: | |
| return Stands(0, 0, StandsStatus.unavailable) | |
| if not data or not data.get('stations', []): | |
| return Stands(0, 0, StandsStatus.unavailable) |
source/jormungandr/jormungandr/parking_space_availability/parking_places_manager.py
Outdated
Show resolved
Hide resolved
xlqian
approved these changes
Sep 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
kadhikari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the bss providers are in the table jormunandr.bss_provider and are shared by all instances (coverages) active (instance.bss_provider = true).
A connector as Cykleo with one organization_id is intialized as a bss_provider, that means there are many bss providers Cykleo as well as JcDeaux.
From now, each new external service for BSS may be integrated in forseti and used in navitia.
One instance of forseti for the same datatype as gbfs.
Same Forseti will be used by one or more instance but with different combination of organization_ids
For details: https://navitia.atlassian.net/browse/NAV-2233